[UX] Alt action to launch games with and without logs #4220
+394
−245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielj
requested review from
Etaash-mathamsetty,
a team,
flavioislima,
CommandMC,
Nocccer and
imLinguin
and removed request for
a team
arielj
commented
Dec 29, 2024
| src={art_background || art_cover} | ||
| className="backgroundImage" | ||
| <SettingsContext.Provider value={settingsContextValues}> | ||
| <div className="gameConfigContainer"> |
There was a problem hiding this comment.
the diff here is a mess, but I'm just wrapping things in a SettingsContext wrapper, nothing changed inside this
arielj
commented
Dec 29, 2024
| @@ -274,6 +274,40 @@ | |||
| max-width: 560px; | |||
| } | |||
|
|
|||
| & .playButtons { | |||
There was a problem hiding this comment.
this CSS is partially duplicated on purpose for both old and new design, eventually we'll remove the old styles and it's easier to do that with duplications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an alternative "Play Now (with logs)" action right next to the normal
Play Nowbutton in the details page behind a small dropdown.The idea is that users can easily select to launch a game with and without logs enabled for debugging purposes (and it's easier to instruct to do that and easier to discover).
The main action will be the last one used so users can clearly see if they are running the game with/without logs as a reminder that they can disable them, and both actions will change the game's settings so it's persisted (this way it can be used for things like running as a non-steam game and log things at the same time).
This depends on my previous PR making the logs configurable in a game-by-game basis.
play-logs.mp4
Use the following Checklist if you have changed something on the Backend or Frontend: