Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Enable Gamescope toggle #4224

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Etaash-mathamsetty
Copy link
Member

Should fix some of the confusion that was caused by the additional options text field

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

gameSettings.gamescope?.enableUpscaling) &&
!isSteamDeckGameMode
) {
if (gameSettings.gamescope?.enableGamescope && !isSteamDeckGameMode) {
Copy link
Collaborator

@arielj arielj Dec 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this change we'll be disabling gamescope for all users that currently have it configured with the other checkboxes until they go and manually enable it

Maybe we need some code setting the initial enableGamescope setting to be the value of gameSettings.gamescope?.enableLimiter || gameSettings.gamescope?.enableUpscaling. Or maybe we can type it as boolean | null and default it to null with null meaning it was never set, use the previous logic?

src/frontend/screens/Settings/components/Gamescope.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants