-
-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Correct names for GE-Proton and umu #4244
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me, I only have one comment but not a blocker (I don't know if it can be fixed): In the Wine version
selector for games settings and default settings, it's showing the old names for protons, but the same thing shows the new name in the wine manager page
Not sure if the selectors can be updated to display the new names (I understand it gets the folder names from the tools folders, maybe the proton ones can be re-formatted during load just for visuals?).
I think it's not a problem for versions in general cause new proton releases will happen and the old names will go away eventually, but the Proton-GE-Latest
shows Proton-GE-Latest
unless you uninstall > install it. I can imagine a user updating their GE-Proton-Latest
in the wine manager and then thinking it didn't work because they se Proton-GE-Latest
in the selector.
Ah yeah, I noticed the folders keeping their own names on update, but I didn't consider that the version detection also reads those folder names. Alternatively, we could also move away from detecting Wine Versions outside of Heroic (especially with umu & GE-Proton becoming the recommended way to run Wine) and take all data from the Wine Manager instead. But that'd involve integrating it a bit more into Heroic logic as a whole (it's quite separate at the moment, which is understandable considering it started out as its own thing) |
Proton-GE got renamed to GE-Proton a bit ago
Secondly, "umu" is not an abbreviation of some kind, it is just a (rather uncommon) word
Use the following Checklist if you have changed something on the Backend or Frontend: