Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Correct names for GE-Proton and umu #4244

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Fix] Correct names for GE-Proton and umu #4244

wants to merge 2 commits into from

Conversation

CommandMC
Copy link
Collaborator

Proton-GE got renamed to GE-Proton a bit ago
Secondly, "umu" is not an abbreviation of some kind, it is just a (rather uncommon) word


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 5, 2025
@CommandMC CommandMC requested a review from a team January 5, 2025 15:29
@CommandMC CommandMC self-assigned this Jan 5, 2025
@CommandMC CommandMC requested review from arielj, flavioislima, Nocccer and imLinguin and removed request for a team January 5, 2025 15:29
public/locales/ar/translation.json Show resolved Hide resolved
src/backend/utils.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, I only have one comment but not a blocker (I don't know if it can be fixed): In the Wine version selector for games settings and default settings, it's showing the old names for protons, but the same thing shows the new name in the wine manager page

Not sure if the selectors can be updated to display the new names (I understand it gets the folder names from the tools folders, maybe the proton ones can be re-formatted during load just for visuals?).

I think it's not a problem for versions in general cause new proton releases will happen and the old names will go away eventually, but the Proton-GE-Latest shows Proton-GE-Latest unless you uninstall > install it. I can imagine a user updating their GE-Proton-Latest in the wine manager and then thinking it didn't work because they se Proton-GE-Latest in the selector.

@CommandMC
Copy link
Collaborator Author

Ah yeah, I noticed the folders keeping their own names on update, but I didn't consider that the version detection also reads those folder names.
We can't really rename the actual folders, as that'll break configs, so I guess a visual solution (as you mentioned) it is.

Alternatively, we could also move away from detecting Wine Versions outside of Heroic (especially with umu & GE-Proton becoming the recommended way to run Wine) and take all data from the Wine Manager instead. But that'd involve integrating it a bit more into Heroic logic as a whole (it's quite separate at the moment, which is understandable considering it started out as its own thing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants