Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Add option to backup saves after closing a game #4247

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jan 5, 2025

I'm not 100% convinced about this feature as implemented in this PR. I do think that having a way to backup save files before doing some sync is a good idea because I've seen many support tickets of users playing around with cloud saves and ending up losing their saves for different reasons.

This PR adds an option to copy the saves of a game into Heroic's config folder after the game closes if it supports cloud saves and they are enabled.

I think we can only implement this for games with cloud saves since those are the ones we can know the save path from the metadata.

I don't know if the approach here is the best idea so I'm open to any feedback. Other options could be:

  • backup BEFORE syncing when launching a game
  • backup BEFORE syncing both when launching a game and when running the sync manually (maybe this is safer for what I'm trying to avoid?)
  • backup with a button (though users might expect some kind of restore button in that case)

I also don't know how big save files can get (I know GOG added some limits, but I don't know about Epic). Maybe we have to put some limit in the number of backups per game? I'm not sure either


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 5, 2025
@arielj arielj requested review from Etaash-mathamsetty, a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team January 5, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant