Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : the issue with the success message not displaying after deployment #1072

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mariatouil
Copy link
Contributor

Description:
This pull request addresses the bug where the success message (#deploy-success-msg) was not displayed after a successful deployment, even when the process reached 100% ,addressing issue #1071

Changes Made:
Verified that the message appears consistently after deployment completion.

success-deploy.mp4

@jelveh
Copy link
Contributor

jelveh commented Dec 27, 2024

I can't reproduce this issue. Even if I did, the window.reload way of updating the app state is not correct.

@mariatouil
Copy link
Contributor Author

@jelveh These two lines:

$('.new-app-modal').get(0).close();
window.location.reload();

actually address a different issue that has already been fixed: resolve issue #983 - Stuck on "Creating new app" loading screen.

I had already submitted a pull request for this, and it was merged. However, when cloning the project, I couldn't find these modifications in the codebase, so I added them directly to resolve both problems simultaneously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants