Add Submodule #70
Merged
Add Submodule #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf-kklein
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
es ist ein vorteil, dass es viele explizite test-daten enthält. gleichzeitig macht es das pflegeintensiv. man könnte überlegen, ob man eine eigene pytest-fixture schreibt, die all matchenden files aus dem submodule yielded, dann müsste man nicht z.b. bei einem upgrade des submodules auch die dateipfade ändern. andererseits gäb's dann aber keine lösung für den check auf das date (was sowaswie ein minimal sanity check ist)
unittests/test_ahb_serialisierung.py
Outdated
Comment on lines
109
to
112
| # pytest.param( | ||
| # data_path / "CONTRL" / "CONTRL_MIG_2_0b_ausserordentliche_2024_07_26_2022_10_01xml", | ||
| # date(2024, 7, 26), | ||
| # ), |
There was a problem hiding this comment.
was ist hier das problem? gehst du das in einem nächsten PR an?
kannst ja ggf. schonmal ein issue aufmachen.
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.