Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bing-wallpaper: update livecheck #178638

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

khipp
Copy link
Member

@khipp khipp commented Jul 5, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Related to #171006.

@BrewTestBot BrewTestBot added the missing zap Cask is missing a zap stanza, please add one. label Jul 5, 2024
@khipp khipp force-pushed the update-bing-wallpaper branch 3 times, most recently from be6811a to c1bf48e Compare July 5, 2024 11:47
@BrewTestBot BrewTestBot removed the missing zap Cask is missing a zap stanza, please add one. label Jul 5, 2024
@p-linnane p-linnane requested a review from samford July 5, 2024 18:35
@chenrui333 chenrui333 added the livecheck Issues or PRs related to livecheck label Jul 5, 2024
Copy link
Member

@samford samford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This livecheck approach looks fine to me. Outside of the comment below, this looks reasonable to me, provided the cask maintainers don't have any issues.

Casks/b/bing-wallpaper.rb Outdated Show resolved Hide resolved
@khipp khipp force-pushed the update-bing-wallpaper branch from c1bf48e to 35d0488 Compare July 8, 2024 03:22
@p-linnane p-linnane merged commit 9a6e5f0 into Homebrew:master Jul 9, 2024
9 checks passed
@khipp khipp deleted the update-bing-wallpaper branch July 9, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants