updated duet (1.5.4.9)

[tsparber]

Changes to a cask

Editing an existing cask

• Commit message includes cask’s name (and new version, if applicable).
• brew cask audit --download {{cask_file}} is error-free.
• brew cask style --fix {{cask_file}} left no offenses.

[tsparber]

Updating the appcast checkpoint is hard, as manual changes get overwritten by cask-repair and cask-repair does not follow the redirect.

[adidalal]

Pinging @vitorgalvao about cask-repair

[adidalal]

Doesn't Duet not work, anyway? #14952

[vitorgalvao]

cask-repair does not follow the redirect

It should. What version are you using (get it with brew info cask-repair; if you installed manually, there’s no way to know)?

[adidalal]

Latest version reports:

• appcast is probably incorrect, as a non-200 (OK) HTTP response code was returned (302)

But what @tsparber is noting is that even if you manually edit, cask-repair will revert that edit when it rechecks after the manual edit

[vitorgalvao]

Reverting the edit happens both with checkpoint: and sha256. It’s by design, as you’re not supposed to do them by hand (it’s an obtuse value that you need a computer to calculate anyway, so let the computer do all the work). For that reason I don’t intend to change that behaviour, as I believe the intent to be correct.

As for the message, it says “probably” precisely to allow some leverage. @tsparber swayed me in the past (on the script to find sparkle appcasts) on following appcast redirects, which is why cask-repair also (should be, anyway) follows them. It’s a warning, not an error, as it is just meant to ask you if you’re sure, in a way. It does not stop you submitting (not passing audit, for example, does).

So my question is if the latest version of cask-repair is really not following redirects, and hence not getting the correct checkpoint:. Making it get the correct checkpoint: automatically is the solution, not allowing manually editing it.

[vitorgalvao]

Just looked at it, and cask-repair seems to be working well. The problem, though, is that the appcast url is redirecting to an old version 1.5.1.1, so no wonder no change is detected — there is none.

Which leads to the question: to what checkpoint: value are you trying to change it, @tsparber?

[tsparber]

Sorry, I was a bit sloppy on this one. I'm using the latest version of cask-repair (0.23.1 as reported by brew info).
I was confused by the warning about the non-200 status code and run the command to get the checkpoint manually (from doc/.../appcast), which indeed does not follow the redirect and got me a different (wrong) checkpoint.
So cask-repair works correctly (apart from the a little bit misleading warning), the appcast.md might need an update (#20490).

Doesn't Duet not work, anyway? #14952

I does work, because it moves itself to /Application and needs to started from there. What does not work is, when a user has the --appdir set to /Application (and so a symlink exists, which does not get overwritten by the app itself). The #14952 (comment) suggests just to wait for #13201.