-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xclogparser: staticly link Swift stdlib on Linux #195226
Conversation
72b19b6
to
61a47e5
Compare
9371c65
to
420c3b2
Compare
Ok looks like I need to merge Swift 6 first for this to work so will do that. |
420c3b2
to
1110daa
Compare
1110daa
to
a1d9107
Compare
a1d9107
to
0893d2c
Compare
Interesting that Sonoma works. I thought it would fail with Xcode 16. |
I think it's a change in Foundation rather than the compiler. Something like MobileNativeFoundation/XCLogParser#217 probably fixes it (though does assume the input is null-terminated which I'm not entirely sure is safe or not). |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
this is needed for xclogparser 0.2.40 build, 1024jp/GzipSwift#71 |
There's already an In any case, the main problem here is that xclogparser itself still doesn't support Swift 6. xclogparser 0.2.40 doesn't fix that as it doesn't include MobileNativeFoundation/XCLogParser#217. |
This doesn't build on Swift 6 on macOS so might not on Linux. We won't be offering a
swift@5
.Revision bump as the Swift PR will otherwise break this.