Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xclogparser: staticly link Swift stdlib on Linux #195226

Closed
wants to merge 1 commit into from

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Oct 22, 2024

This doesn't build on Swift 6 on macOS so might not on Linux. We won't be offering a swift@5.

Revision bump as the Swift PR will otherwise break this.

@Bo98 Bo98 changed the title xlogparser: staticly link Swift stdlib on Linux xclogparser: staticly link Swift stdlib on Linux Oct 22, 2024
@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. swift Swift use is a significant feature of the PR or issue labels Oct 22, 2024
@Bo98 Bo98 force-pushed the xclogparser-static-linux branch from 72b19b6 to 61a47e5 Compare October 22, 2024 14:53
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 22, 2024
@Bo98 Bo98 force-pushed the xclogparser-static-linux branch 4 times, most recently from 9371c65 to 420c3b2 Compare October 22, 2024 15:28
@Bo98
Copy link
Member Author

Bo98 commented Oct 22, 2024

Ok looks like I need to merge Swift 6 first for this to work so will do that.

@cho-m cho-m force-pushed the xclogparser-static-linux branch from 420c3b2 to 1110daa Compare November 9, 2024 18:59
@cho-m cho-m added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Nov 9, 2024
@daeho-ro daeho-ro force-pushed the xclogparser-static-linux branch from 1110daa to a1d9107 Compare November 11, 2024 21:40
@cho-m cho-m force-pushed the xclogparser-static-linux branch from a1d9107 to 0893d2c Compare November 16, 2024 00:10
@cho-m
Copy link
Member

cho-m commented Nov 23, 2024

Interesting that Sonoma works. I thought it would fail with Xcode 16.

@Bo98
Copy link
Member Author

Bo98 commented Nov 23, 2024

I think it's a change in Foundation rather than the compiler. Something like MobileNativeFoundation/XCLogParser#217 probably fixes it (though does assume the input is null-terminated which I'm not entirely sure is safe or not).

@chenrui333 chenrui333 mentioned this pull request Nov 30, 2024
1 task
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Dec 14, 2024
@daeho-ro daeho-ro removed the stale No recent activity label Dec 16, 2024
@daeho-ro daeho-ro mentioned this pull request Dec 17, 2024
6 tasks
@chenrui333 chenrui333 mentioned this pull request Dec 17, 2024
@chenrui333
Copy link
Member

this is needed for xclogparser 0.2.40 build, 1024jp/GzipSwift#71

@Bo98
Copy link
Member Author

Bo98 commented Dec 17, 2024

There's already an inreplace here to fix that, though that of course is a hack. Ideally an upstream fix would be something that allows any arbitrary include path (rather than having something for each of the various package managers). That upstream patch as-is wouldn't really work for us as it would we would want to prioritise Homebrew over system in our case.

In any case, the main problem here is that xclogparser itself still doesn't support Swift 6. xclogparser 0.2.40 doesn't fix that as it doesn't include MobileNativeFoundation/XCLogParser#217.

@github-actions github-actions bot deleted the xclogparser-static-linux branch December 18, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. swift Swift use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants