Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to PropertyNamingStrategyBase #113

Merged
merged 3 commits into from
Dec 30, 2023
Merged

Remove references to PropertyNamingStrategyBase #113

merged 3 commits into from
Dec 30, 2023

Conversation

jhaber
Copy link
Member

@jhaber jhaber commented Dec 30, 2023

Resolves #110

@jhaber jhaber mentioned this pull request Dec 30, 2023
Closed
@jhaber
Copy link
Member Author

jhaber commented Dec 30, 2023 •
edited
Loading

Instead of special-casing PropertyNamingStrategyBase/NamingBase, we just call PropertyNamingStrategy#nameForField directly. Historically we didn't do this because constructing the required arguments is not easy/possible (AnnotatedField in particular). However, if we can't construct an AnnotatedField we just pass null and hope that the underlying naming strategy doesn't care (none of the Jackson built-in naming strategies should)

@jhaber jhaber changed the title Remove references to PropertyNamingStrategyBase @jhaber Remove references to PropertyNamingStrategyBase Dec 30, 2023
@jhaber
Copy link
Member Author

jhaber commented Dec 30, 2023

This PR also includes some breaking changes to constructors/methods that were technically public, but I think the risk of them being used externally is pretty low

@jhaber jhaber merged commit ad50263 into master Dec 30, 2023
5 checks passed
@jhaber jhaber deleted the jh/rm-naming-strategy-base branch December 30, 2023 14:35
This was referenced Dec 30, 2023
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warnings emitted when used with Jackson >= 2.16.0 due to use of deprecated PropertyNamingStrategy subclasses
1 participant
@jhaber