Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DIA-1740: 'int' not iterable when Rating GT empty #163

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Conversation

hakan458
Copy link
Contributor

@hakan458 hakan458 commented Dec 11, 2024

Most control tags' labels are stored in a list, for some like Number and Rating it is just a single int. We were not handling the case where the annotation to compare against is emtpy, for a Rating / Number tag

Fixed DIA-1741 here as well. We were never calculating pairwise comparisons correctly. We were catching an exception in the case both annotation and pred have non-empty pairwise selection, but issue manifested when GT was empty
We were using the wrong key all along

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.26%. Comparing base (74e171a) to head (3dafebd).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
evalme/classification.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
- Coverage   70.32%   70.26%   -0.06%     
==========================================
  Files          26       26              
  Lines        2746     2748       +2     
==========================================
  Hits         1931     1931              
- Misses        815      817       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hakan458 hakan458 merged commit 47e9821 into master Dec 12, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants