Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DRMacIver as code owner #4218

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Add DRMacIver as code owner #4218

merged 1 commit into from
Jan 4, 2025

Conversation

DRMacIver
Copy link
Member

@DRMacIver DRMacIver commented Dec 29, 2024

I was going to review #4217 and realised I couldn't actually approve it as I'm not listed as a code owner for conjecture. Seemed appropriate to fix this given that I'm getting more involved in Hypothesis again.

@DRMacIver DRMacIver requested a review from Zac-HD December 29, 2024 11:07
Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome back!

IIRC this will "require" each of us to have any changes reviewed by the other, but if that gets annoying we both also have the "ignore requirements" admin override 🙂 (avoiding overuse of which is why changed this in the first place)

@Zac-HD Zac-HD merged commit 5565708 into master Jan 4, 2025
49 checks passed
@DRMacIver DRMacIver deleted the DRMacIver/codeowner branch January 4, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants