Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svgoutput #363

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Svgoutput #363

wants to merge 4 commits into from

Conversation

anikde07
Copy link
Collaborator

@anikde07 anikde07 commented Nov 4, 2024

#336 Added .svg as a download option. Fixed heatmap plot by replacing heatmap_plot with res_tmp[[session$token]][["Heatmap"]]$plot in the saving function.

@LeaSeep LeaSeep self-requested a review November 5, 2024 07:42
@PaulJonasJost PaulJonasJost requested review from PaulJonasJost and removed request for LeaSeep November 6, 2024 15:57
Copy link
Collaborator

@LeaSeep LeaSeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major:

  • Volcano plot downloads as svgs

Minor:
(either solve yourself within this PR or open a new issue)

  • saving names for heatmap are just the date - should be at least "Heatmap_[DATE]"

@anikde07
Copy link
Collaborator Author

Hi Lea,

Screenshot from 2024-12-10 15-39-47

I am not sure I understand the first issue you pointed out. I can save the violin plot as svg.
Is this what you were referring to? Or was it something else?

@LeaSeep
Copy link
Collaborator

LeaSeep commented Dec 11, 2024

The shown screenshot are violin plots, I was referring to the Volcano plot (under significance analysis -> choose a comparison -> select Volcano

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants