doc: switch back to libclang to avoid hardcoding LLVM version #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The libclang package has an embedded copy of libclang, which allows us to avoid requiring the system to have a particular clang version. This didn't work before because the lib_search_dirs logic in conf.py was clobbering a working path with a broken one. That logic is no longer needed, so just remove it.
|
Oh nice. Let's try this! |
|
Sadly this breaks on readthedocs with what looks like a clang14 / clang16 mismatch error: The build error report says: |
|
Maybe |
|
Recent readthedocs builds are here: https://readthedocs.org/projects/libdicom/builds/ |
|
Oof. I wonder why it works on vanilla 22.04 and fails on ReadTheDocs. Maybe we can use a separate |
|
Yes, it's a bit annoying, I spent a morning getting readthedocs working :( I wish it was simpler. I'll revert this commit for now to get the docs building again. |
|
They have their build images here, fwiw: https://github.com/readthedocs/readthedocs-docker-images |
|
Second attempt in #74. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
libclangpackage has an embedded copy of libclang, which allows us to avoid requiring the system to have a particular clang version. This didn't work before because thelib_search_dirslogic inconf.pywas clobbering a working path with a broken one. That logic is no longer needed, so just remove it.Tested on Fedora 38 and Ubuntu 22.04, but not specifically tested with Read the Docs.