Explicitly fail if macOS universal build is attempted #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain Meson compiler checks fail if CFLAGS has `-arch x86_64 -arch arm64`. This was causing us not to set HAVE_UNISTD_H, and then to fail the build on an implicit function declaration. Detect this configuration during setup and fail with a clearer error. https://trac.macports.org/ticket/69676
bgilbert
added a commit
to macports/macports-ports
that referenced
this pull request
Apr 8, 2024
Certain Meson checks don't work properly for universal builds, causing libdicom to skip including unistd.h and then fail the build on an implicit function declaration. Use muniversal to build each arch separately. Fixes: https://trac.macports.org/ticket/69676 See: ImagingDataCommons/libdicom#86
|
Thanks Benjamin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain Meson compiler checks fail if CFLAGS has
-arch x86_64 -arch arm64. This was causing us not to setHAVE_UNISTD_H, and then to fail the build on an implicit function declaration. Detect this configuration during setup and fail with a clearer error.https://trac.macports.org/ticket/69676