Fix: Propagate sub-command exit status #2927
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
This PR fixes the handling of subcommand exit statuses to ensure the Go program propagates the exit code correctly. Previously, subcommands returning non-zero exit codes were treated as errors, which could lead to misleading error messages and incorrect behavior. This update ensures the Go program exits with the same status code as the executed subcommand, aligning with expected behavior.
Type ✨
Tests 🛠️
The following tests were performed to verify the changes:
1. Successful Subcommand: Verified that the Go program exits with 0 for subcommands that finish successfully.
2. Non-Zero Exit Code: Verified that the Go program exits with the same non-zero code as subcommands that terminate with a specific exit status.