drop deprecated css.Job indexing functionality (#1013)

for backwards compatibility #691 added a special case treating
`index=None` like `index=0`, with a deprecation warning, when retrieving
some attributes from css jobs containing a single circuit. It's now been
~9 months, so we can probably drop this in favor of more consistent
return typing

cirq-superstaq/cirq_superstaq/job.py

@@ -16,7 +16,6 @@
 
 import collections
 import time
-import warnings
 from collections.abc import Sequence
 from typing import Any, overload
 
@@ -174,10 +173,7 @@ def target(self) -> str:
     def num_qubits(self, index: int) -> int: ...
 
     @overload
-    def num_qubits(
-        self, index: None = None
-    ) -> int | list[int]:  # Change return to `list[int]` after deprecation
-        ...
+    def num_qubits(self, index: None = None) -> list[int]: ...
 
     def num_qubits(self, index: int | None = None) -> int | list[int]:
         """Gets the number of qubits required for each circuit in this job.
@@ -200,18 +196,7 @@ def num_qubits(self, index: int | None = None) -> int | list[int]:
             self._refresh_job()
 
         if index is None:
-            qubit_list = [self._job[job_id]["num_qubits"] for job_id in job_ids]
-            if len(qubit_list) == 1:
-                warnings.warn(
-                    "In the future, calling `num_qubits()` without an argument will return a list "
-                    "of the numbers of qubits in all circuits in this job. Use e.g., "
-                    "`num_qubits(0)` to get the number of qubits in the first (or a single) "
-                    "circuit.",
-                    DeprecationWarning,
-                    stacklevel=2,
-                )
-                return qubit_list[0]
-            return qubit_list
+            return [self._job[job_id]["num_qubits"] for job_id in job_ids]
 
         gss.validation.validate_integer_param(index, min_val=0)
         num_qubits = self._job[job_ids[index]]["num_qubits"]
@@ -237,12 +222,7 @@ def repetitions(self) -> int:
     def _get_circuits(self, circuit_type: str, index: int) -> cirq.Circuit: ...
 
     @overload
-    def _get_circuits(
-        self, circuit_type: str, index: None = None
-    ) -> (
-        cirq.Circuit | list[cirq.Circuit]
-    ):  # Change return to `list[cirq.Circuit]` after deprecation
-        ...
+    def _get_circuits(self, circuit_type: str, index: None = None) -> list[cirq.Circuit]: ...
 
     def _get_circuits(
         self, circuit_type: str, index: int | None = None
@@ -278,12 +258,7 @@ def _get_circuits(
     def compiled_circuits(self, index: int) -> cirq.Circuit: ...
 
     @overload
-    def compiled_circuits(
-        self, index: None = None
-    ) -> (
-        cirq.Circuit | list[cirq.Circuit]
-    ):  # Change return to `list[cirq.Circuit]` after deprecation
-        ...
+    def compiled_circuits(self, index: None = None) -> list[cirq.Circuit]: ...
 
     def compiled_circuits(self, index: int | None = None) -> cirq.Circuit | list[cirq.Circuit]:
         """Gets the compiled circuits that were processed for this job.
@@ -300,12 +275,7 @@ def compiled_circuits(self, index: int | None = None) -> cirq.Circuit | list[cir
     def input_circuits(self, index: int) -> cirq.Circuit: ...
 
     @overload
-    def input_circuits(
-        self, index: None = None
-    ) -> (
-        cirq.Circuit | list[cirq.Circuit]
-    ):  # Change return to `list[cirq.Circuit]` after deprecation
-        ...
+    def input_circuits(self, index: None = None) -> list[cirq.Circuit]: ...
 
     def input_circuits(self, index: int | None = None) -> cirq.Circuit | list[cirq.Circuit]:
         """Gets the original circuits that were submitted for this job.
@@ -377,10 +347,7 @@ def counts(
         timeout_seconds: int = 7200,
         polling_seconds: float = 1.0,
         qubit_indices: Sequence[int] | None = None,
-    ) -> (
-        dict[str, int] | list[dict[str, int]]
-    ):  # Change return to just `list[dict[str, int]]` after deprecation
-        ...
+    ) -> list[dict[str, int]]: ...
 
     def counts(
         self,
@@ -424,15 +391,6 @@ def counts(
                 counts_list = [
                     _get_marginal_counts(counts, qubit_indices) for counts in counts_list
                 ]
-            if len(counts_list) == 1:
-                warnings.warn(
-                    "In the future, calling `counts()` without an argument will return a list of "
-                    "the counts in all circuits in this job. Use e.g., `counts(0)` to get the "
-                    "counts for the first (or a single) circuit.",
-                    DeprecationWarning,
-                    stacklevel=2,
-                )
-                return counts_list[0]
             return counts_list
 
         gss.validation.validate_integer_param(index, min_val=0)

cirq-superstaq/cirq_superstaq/job_test.py

@@ -119,10 +119,7 @@ def test_num_qubits(job: css.job.Job) -> None:
 
     # Shouldn't need to retrieve anything now that `job._job` is populated:
     assert job.num_qubits(index=0) == 2
-
-    # Deprecation warning test
-    with pytest.warns(DeprecationWarning, match="the numbers of qubits in all circuits"):
-        assert job.num_qubits() == 2
+    assert job.num_qubits() == [2]
 
 
 def test_repetitions(job: css.job.Job) -> None:
@@ -383,10 +380,7 @@ def test_job_counts(job: css.job.Job) -> None:
     with patched_requests({"job_id": job_dict}):
         assert job.counts(index=0) == {"10": 1}
         assert job.counts(index=0, qubit_indices=[0]) == ({"1": 1})
-
-    # Deprecation warning test
-    with pytest.warns(DeprecationWarning, match="the counts in all circuits in this"):
-        assert job.counts() == {"10": 1}
+        assert job.counts() == [{"10": 1}]
 
 
 def test_job_counts_failed(job: css.job.Job) -> None:

cirq-superstaq/docs/getting_started_cirq_superstaq.ipynb

@@ -182,7 +182,7 @@
    "source": [
     "job = service.create_job(circuit, repetitions=1, target=\"aws_sv1_simulator\", method=\"dry-run\")\n",
     "print(\"Job status: \", job.status())\n",
-    "print(job.counts())"
+    "print(job.counts(0))"
    ]
   }
  ],

cirq-superstaq/docs/ibm_cirq_superstaq.ipynb

@@ -201,7 +201,7 @@
    "source": [
     "job = service.create_job(circuit, repetitions=1, target=\"ibmq_brisbane_qpu\", method=\"dry-run\")\n",
     "print(\"Job status: \", job.status())\n",
-    "print(job.counts())"
+    "print(job.counts(0))"
    ]
   }
  ],

docs/source/get_started/basics/basics_css.ipynb

@@ -170,7 +170,7 @@
     "    target=\"ibmq_brisbane_qpu\",\n",
     "    repetitions=100,\n",
     ")\n",
-    "result = job.counts()\n",
+    "result = job.counts(0)\n",
     "print(result)"
    ]
   }

docs/source/optimizations/ibm/ibmq_compile_css.ipynb

@@ -469,7 +469,7 @@
     ")\n",
     "\n",
     "# Get the counts from the measurement\n",
-    "print(job.counts())"
+    "print(job.counts(0))"
    ]
   }
  ],