Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EeroQ notebook updates #1126

Merged
merged 6 commits into from
Dec 14, 2024
Merged

EeroQ notebook updates #1126

merged 6 commits into from
Dec 14, 2024

Conversation

bharat-thotakura
Copy link
Contributor

Cleans up the EeroQ optimization notebooks to be closer in standardization to the other hardware optimization notebooks

(additionally contains very minor nits for the QSCOUT notebook discovered via editing the EeroQ notebooks)

Signed-off-by: Bharath <bharath.thotakura@infleqtion.com>
Signed-off-by: Bharath <bharath.thotakura@infleqtion.com>
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Signed-off-by: Bharath <bharath.thotakura@infleqtion.com>
Signed-off-by: Bharath <bharath.thotakura@infleqtion.com>
@vtomole vtomole requested a review from pgoiporia December 12, 2024 16:31
@vtomole
Copy link
Member

vtomole commented Dec 12, 2024

From dev meeting: @PalashGoiporia to review.

@@ -18,18 +18,20 @@
},
Copy link
Contributor

@pgoiporia pgoiporia Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably doesn't need to be a subheading.


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it looked weird to me too in ReviewNB, but it's not set as a subheading afaict:
image

Will correct in a follow-up PR if its wrong on Read-the-docs too

@@ -18,18 +18,20 @@
},
Copy link
Contributor

@pgoiporia pgoiporia Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here


Reply via ReviewNB

Copy link
Contributor

@pgoiporia pgoiporia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once you make those tiny tweaks. Thanks for making these changes, the notebook looks much better!

@bharat-thotakura bharat-thotakura merged commit c8e41b9 into main Dec 14, 2024
21 checks passed
@bharat-thotakura bharat-thotakura deleted the eeroq-notebook-updates branch December 14, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants