Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update max sharpe notebook #1132

Merged
merged 7 commits into from
Dec 26, 2024
Merged

update max sharpe notebook #1132

merged 7 commits into from
Dec 26, 2024

Conversation

richrines1
Copy link
Contributor

we exclude this one from pytest but include it in our docs, and currently it won't run correctly (due to changes in yfinance i think?)

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@bharat-thotakura bharat-thotakura self-assigned this Dec 23, 2024
Copy link
Contributor

@bharat-thotakura bharat-thotakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking at this! LGTM % comments/questions

(was able to run the notebook locally without issue ... except the cell that calls Wikipedia, but I'm having trouble with Wikipedia outside of this notebook anyway so most likely not universal)

@richrines1 richrines1 merged commit 7744a71 into main Dec 26, 2024
21 checks passed
@richrines1 richrines1 deleted the rich/max-sharpe-nb branch December 26, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants