Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant examples #1137

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

remove redundant examples #1137

wants to merge 2 commits into from

Conversation

richrines1
Copy link
Contributor

the examples/ subdirectories in css and qss have been superseded by the docs/ directory

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@bharat-thotakura bharat-thotakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently don't have a notebook to showcase the resource_estimate() method on read-the-docs. Do we want a full notebook for it or is the API reference and docstring sufficient? Alternatively, we could have a dedicated 'advanced/general superstaq features' notebook as a sequel to basics & account_info that highlights things like resource_estimate, and features like in #761

@richrines1
Copy link
Contributor Author

i think we decided way back that resource_estimate() itself didn't really warrant a demo yet? (the endpoint is pretty under-developed atm, and will probably change substantially before it's useful)

that said i do really like the idea of adding an "advanced features" demo before the device-specific stuff. it also seems like the "basics" notebooks themselves could be extended a bit - currently they only showcase submission, but imo should at least demo compilation as well

Copy link
Contributor

@bharat-thotakura bharat-thotakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, I wasn't aware of that decision. But yeah, I agree with the reasoning given the current state of resource_estimate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants