Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting circuit retrieval #728

Merged
merged 15 commits into from
Oct 13, 2023
Merged

Documenting circuit retrieval #728

merged 15 commits into from
Oct 13, 2023

Conversation

stephanielee9
Copy link
Contributor

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@bharat-thotakura
Copy link
Contributor

bharat-thotakura commented Sep 11, 2023

Related: #743

Edit: css now accepts a list of circuits (see #691).

Copy link
Contributor

@bharat-thotakura bharat-thotakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates lgtm! Just added some minor comments based on the latest PR merges

Copy link
Contributor

@bharat-thotakura bharat-thotakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notebook check should pass after updating css notebooks with: input_circuit(index=0) -> input_circuits(index=0) and compiled_circuit(index=0) -> compiled_circuits(index=0)

(the _circuit bit was made plural after #691)

Also, just remembered that the css notebook should also use index for: num_qubits(index=0) and counts(index=0) as well to avoid the deprecation warning

Copy link
Contributor

@bharat-thotakura bharat-thotakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review comments addressed by d301c28, de71160 and d58407d.

@stephanielee9 stephanielee9 merged commit 43c2482 into main Oct 13, 2023
16 checks passed
@stephanielee9 stephanielee9 deleted the add-get-circuit branch October 13, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants