Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing of dd_strategy kwargs in compile #824

Merged
merged 8 commits into from
Oct 23, 2023
Merged

Fix passing of dd_strategy kwargs in compile #824

merged 8 commits into from
Oct 23, 2023

Conversation

paaige
Copy link
Contributor

@paaige paaige commented Oct 19, 2023

No description provided.

@richrines1
Copy link
Contributor

needs superstaq_provider too i think

@richrines1
Copy link
Contributor

can we also add something like this:

assert json.loads(mock_post.call_args.kwargs["json"]["options"]) == {
"mirror_swaps": False,
"base_entangling_gate": "xx",
"num_qubits": 2,
}

(but with dd_strategy/etc) to test_ibmq_compile as a regression test?

@paaige
Copy link
Contributor Author

paaige commented Oct 19, 2023

can we also add something like this:

assert json.loads(mock_post.call_args.kwargs["json"]["options"]) == {
"mirror_swaps": False,
"base_entangling_gate": "xx",
"num_qubits": 2,
}

(but with dd_strategy/etc) to test_ibmq_compile as a regression test?

Added tests to all (css:service, qss:provider/backend)

@richrines1
Copy link
Contributor

Added tests to all (css:service, qss:provider/backend)

thanks! does the service_test update still need to be pushed by any chance? looks like the file is unchanged

@paaige
Copy link
Contributor Author

paaige commented Oct 20, 2023

Added tests to all (css:service, qss:provider/backend)

thanks! does the service_test update still need to be pushed by any chance? looks like the file is unchanged

... yeah, good catch! thanks

Copy link
Contributor

@richrines1 richrines1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % formatting! thanks for catching this

@paaige paaige merged commit c1b8332 into main Oct 23, 2023
16 checks passed
@paaige paaige deleted the fix_dd_strategy branch October 23, 2023 21:42
richrines1 added a commit that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants