Check for Hilbert availability before submitting #845
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtomole
requested review from
dowusu-antwi,
singular-value,
stephanielee9,
paaige,
richrines1 and
epelaaez
as code owners
Comment on lines
+306
to
+309
| @pytest.mark.skipif( | ||
| "cq_hilbert_qpu" not in css.Service().get_targets()["compile-and-run"], | ||
| reason="Can't be executed when Hilbert is set to not accept jobs", | ||
| ) |
There was a problem hiding this comment.
Post v0.5.0, (see #788 and https://github.com/Infleqtion/server-superstaq/pull/2822) get_targets() no longer returns a dictionary and hence doesn't have a ["compile-and-run"] anymore. You would have to do something like:
cq_target = gss.typing.Target(
target="cq_hilbert_qpu",
supports_submit=False,
supports_submit_qubo=False,
supports_compile=True,
available=True,
retired=False,
)
cq_target not in css.Service().get_targets()or maybe:
non_submit_targets = [Target.target for Target in css.Service().get_targets(supports_submit=False)]
"cq_hilbert_qpu" in non_submit_targetsThis also assumes that the supports_submit flag will automatically be set to False when "cq_hilbert_qpu" is not available which would require server-side changes
| @pytest.mark.skip(reason="Can't be executed when Hilbert is set to not accept jobs") | ||
| @pytest.mark.skipif( | ||
| "cq_hilbert_qpu" | ||
| not in qss.SuperstaqProvider()._client.get_targets()["superstaq_targets"]["compile-and-run"], |
There was a problem hiding this comment.
See previous comment. Also, I think you should be able to call get_targets() directly from qss.SuperstaqProvider() since it inherits from gss.service.Service() which contains a get_targets() wrapper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been pulled from #827 except it assigns me and doesn't separate the test. Going to try this out before merging the other PR.