-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/ibc connection module queries #167
Conversation
WalkthroughThe recent updates focus on enhancing documentation and API interaction across various modules. Format improvements in multiple markdown files ensure better readability, while the addition of new modules and comprehensive JSON schemas in the IBC and Tendermint areas enhance functionality and clarity in data handling and API usage. Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (121)
Files not summarized due to errors (3)
Files skipped from review due to trivial changes (39)
Additional comments not posted (123)
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
[ | ||
{"Parameter": "p2p", "Type": "Integer", "Description": ""}, | ||
{"Parameter": "block", "Type": "Integer", "Description": ""}, | ||
{"Parameter": "app", "Type": "Integer", "Description": ""} | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add descriptions for the parameters "p2p", "block", and "app" to enhance clarity and usability of the schema.
{"Parameter": "data", "Type": "Bytes", "Description": "Query data", "Required": "No"}, | ||
{"Parameter": "path", "Type": "String", "Description": "Query path", "Required": "Yes"}, | ||
{"Parameter": "haight", "Type": "Integer", "Description": "Block height", "Required": "No"}, | ||
{"Parameter": "prove", "Type": "Boolean", "Description": "", "Required": "No"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a description for the "prove" parameter to enhance clarity.
import asyncio | ||
|
||
from google.protobuf import symbol_database | ||
|
||
from pyinjective.async_client import AsyncClient | ||
from pyinjective.client.model.pagination import PaginationOption | ||
from pyinjective.core.network import Network | ||
|
||
|
||
async def main() -> None: | ||
network = Network.testnet() | ||
client = AsyncClient(network) | ||
|
||
pagination = PaginationOption(skip=2, limit=4) | ||
|
||
states = await client.fetch_ibc_client_states(pagination=pagination) | ||
print(states) | ||
|
||
|
||
if __name__ == "__main__": | ||
symbol_db = symbol_database.Default() | ||
asyncio.get_event_loop().run_until_complete(main()) | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure proper error handling in the Python example for querying all IBC light clients. Currently, exceptions such as network failures or invalid parameters are not handled.
+ try:
states = await client.fetch_ibc_client_states(pagination=pagination)
print(states)
+ except Exception as e:
+ print(f"An error occurred: {e}")
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
import asyncio | |
from google.protobuf import symbol_database | |
from pyinjective.async_client import AsyncClient | |
from pyinjective.client.model.pagination import PaginationOption | |
from pyinjective.core.network import Network | |
async def main() -> None: | |
network = Network.testnet() | |
client = AsyncClient(network) | |
pagination = PaginationOption(skip=2, limit=4) | |
states = await client.fetch_ibc_client_states(pagination=pagination) | |
print(states) | |
if __name__ == "__main__": | |
symbol_db = symbol_database.Default() | |
asyncio.get_event_loop().run_until_complete(main()) | |
``` | |
import asyncio | |
from google.protobuf import symbol_database | |
from pyinjective.async_client import AsyncClient | |
from pyinjective.client.model.pagination import PaginationOption | |
from pyinjective.core.network import Network | |
async def main() -> None: | |
network = Network.testnet() | |
client = AsyncClient(network) | |
pagination = PaginationOption(skip=2, limit=4) | |
try: | |
states = await client.fetch_ibc_client_states(pagination=pagination) | |
print(states) | |
except Exception as e: | |
print(f"An error occurred: {e}") | |
if __name__ == "__main__": | |
symbol_db = symbol_database.Default() | |
asyncio.get_event_loop().run_until_complete(main()) |
func main() { | ||
network := common.LoadNetwork("testnet", "lb") | ||
tmClient, err := rpchttp.New(network.TmEndpoint, "/websocket") | ||
if err != nil { | ||
panic(err) | ||
} | ||
|
||
senderAddress, cosmosKeyring, err := chainclient.InitCosmosKeyring( | ||
os.Getenv("HOME")+"/.injectived", | ||
"injectived", | ||
"file", | ||
"inj-user", | ||
"12345678", | ||
"5d386fbdbf11f1141010f81a46b40f94887367562bd33b452bbaa6ce1cd1381e", // keyring will be used if pk not provided | ||
false, | ||
) | ||
|
||
if err != nil { | ||
panic(err) | ||
} | ||
|
||
clientCtx, err := chainclient.NewClientContext( | ||
network.ChainId, | ||
senderAddress.String(), | ||
cosmosKeyring, | ||
) | ||
|
||
if err != nil { | ||
panic(err) | ||
} | ||
|
||
clientCtx = clientCtx.WithNodeURI(network.TmEndpoint).WithClient(tmClient) | ||
|
||
chainClient, err := chainclient.NewChainClient( | ||
clientCtx, | ||
network, | ||
common.OptionGasPrices(client.DefaultGasPriceWithDenom), | ||
) | ||
|
||
if err != nil { | ||
panic(err) | ||
} | ||
|
||
pagination := query.PageRequest{Offset: 2, Limit: 4} | ||
ctx := context.Background() | ||
|
||
res, err := chainClient.FetchIBCClientStates(ctx, &pagination) | ||
if err != nil { | ||
fmt.Println(err) | ||
} | ||
|
||
fmt.Print(res) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the Go example, consider handling the error right after the json.MarshalIndent
function to check for serialization issues when querying all IBC light clients.
+ str, err := json.MarshalIndent(res, "", " ")
+ if err != nil {
+ fmt.Println("Error marshalling response:", err)
+ return
+ }
fmt.Print(string(str))
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
func main() { | |
network := common.LoadNetwork("testnet", "lb") | |
tmClient, err := rpchttp.New(network.TmEndpoint, "/websocket") | |
if err != nil { | |
panic(err) | |
} | |
senderAddress, cosmosKeyring, err := chainclient.InitCosmosKeyring( | |
os.Getenv("HOME")+"/.injectived", | |
"injectived", | |
"file", | |
"inj-user", | |
"12345678", | |
"5d386fbdbf11f1141010f81a46b40f94887367562bd33b452bbaa6ce1cd1381e", // keyring will be used if pk not provided | |
false, | |
) | |
if err != nil { | |
panic(err) | |
} | |
clientCtx, err := chainclient.NewClientContext( | |
network.ChainId, | |
senderAddress.String(), | |
cosmosKeyring, | |
) | |
if err != nil { | |
panic(err) | |
} | |
clientCtx = clientCtx.WithNodeURI(network.TmEndpoint).WithClient(tmClient) | |
chainClient, err := chainclient.NewChainClient( | |
clientCtx, | |
network, | |
common.OptionGasPrices(client.DefaultGasPriceWithDenom), | |
) | |
if err != nil { | |
panic(err) | |
} | |
pagination := query.PageRequest{Offset: 2, Limit: 4} | |
ctx := context.Background() | |
res, err := chainClient.FetchIBCClientStates(ctx, &pagination) | |
if err != nil { | |
fmt.Println(err) | |
} | |
fmt.Print(res) | |
func main() { | |
network := common.LoadNetwork("testnet", "lb") | |
tmClient, err := rpchttp.New(network.TmEndpoint, "/websocket") | |
if err != nil { | |
panic(err) | |
} | |
senderAddress, cosmosKeyring, err := chainclient.InitCosmosKeyring( | |
os.Getenv("HOME")+"/.injectived", | |
"injectived", | |
"file", | |
"inj-user", | |
"12345678", | |
"5d386fbdbf11f1141010f81a46b40f94887367562bd33b452bbaa6ce1cd1381e", // keyring will be used if pk not provided | |
false, | |
) | |
if err != nil { | |
panic(err) | |
} | |
clientCtx, err := chainclient.NewClientContext( | |
network.ChainId, | |
senderAddress.String(), | |
cosmosKeyring, | |
) | |
if err != nil { | |
panic(err) | |
} | |
clientCtx = clientCtx.WithNodeURI(network.TmEndpoint).WithClient(tmClient) | |
chainClient, err := chainclient.NewChainClient( | |
clientCtx, | |
network, | |
common.OptionGasPrices(client.DefaultGasPriceWithDenom), | |
) | |
if err != nil { | |
panic(err) | |
} | |
pagination := query.PageRequest{Offset: 2, Limit: 4} | |
ctx := context.Background() | |
res, err := chainClient.FetchIBCClientStates(ctx, &pagination) | |
if err != nil { | |
fmt.Println(err) | |
} | |
str, err := json.MarshalIndent(res, "", " ") | |
if err != nil { | |
fmt.Println("Error marshalling response:", err) | |
return | |
} | |
fmt.Print(string(str)) | |
} |
@@ -0,0 +1,3 @@ | |||
[ | |||
{"Parameter": "txs", "Type": "Byte Array", "Description": "Txs that will be applied by state @ block.Height+1. NOTE: not all txs here are valid. We're just agreeing on the order first. This means that block.AppHash does not include these txs."} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider clarifying the description of "txs" to ensure users understand the implications of the transactions not being validated at this stage.
- "Description": "Txs that will be applied by state @ block.Height+1. NOTE: not all txs here are valid. We're just agreeing on the order first. This means that block.AppHash does not include these txs."
+ "Description": "Txs that will be applied by state @ block.Height+1. NOTE: not all txs here are valid. Transactions are ordered first, and validity is assessed later. This means that block.AppHash does not include these txs."
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
{"Parameter": "txs", "Type": "Byte Array", "Description": "Txs that will be applied by state @ block.Height+1. NOTE: not all txs here are valid. We're just agreeing on the order first. This means that block.AppHash does not include these txs."} | |
{"Parameter": "txs", "Type": "Byte Array", "Description": "Txs that will be applied by state @ block.Height+1. NOTE: not all txs here are valid. Transactions are ordered first, and validity is assessed later. This means that block.AppHash does not include these txs."} |
@@ -133,6 +133,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for section titles to improve document structure and accessibility.
@@ -183,6 +184,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for section titles to improve document structure and accessibility.
@@ -339,6 +341,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for section titles to improve document structure and accessibility.
@@ -478,6 +481,7 @@ No parameters | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for section titles to improve document structure and accessibility.
@@ -487,6 +491,7 @@ No parameters | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for section titles to improve document structure and accessibility.
@@ -671,6 +676,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for section titles to improve document structure and accessibility.
@@ -679,6 +685,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for section titles to improve document structure and accessibility.
@@ -856,6 +863,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for section titles to improve document structure and accessibility.
@@ -864,6 +872,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for section titles to improve document structure and accessibility.
@@ -872,6 +881,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for section titles to improve document structure and accessibility.
@@ -1014,6 +1024,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for section titles to improve document structure and accessibility.
@@ -1161,6 +1172,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for section titles to improve document structure and accessibility.
@@ -1169,6 +1181,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for section titles to improve document structure and accessibility.
@@ -1444,6 +1457,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for section titles to improve document structure and accessibility.
@@ -1607,6 +1621,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for section titles to improve document structure and accessibility.
@@ -1615,6 +1630,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for section titles to improve document structure and accessibility.
@@ -1940,6 +1956,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for section titles to improve document structure and accessibility.
@@ -1949,6 +1966,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for section titles to improve document structure and accessibility.
@@ -2403,6 +2421,7 @@ No parameters | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for section titles to improve document structure and accessibility.
@@ -1459,6 +1477,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for "PerpetualMarketInfo".
Using emphasis (**PerpetualMarketInfo**
) instead of a proper heading (e.g., ### PerpetualMarketInfo
) might affect the document's structure and readability, especially in markdown renderers that use headings to generate navigation menus.
@@ -1470,6 +1489,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for "PerpetualMarketFunding".
Using emphasis (**PerpetualMarketFunding**
) instead of a proper heading (e.g., ### PerpetualMarketFunding
) might affect the document's structure and readability, especially in markdown renderers that use headings to generate navigation menus.
@@ -1479,6 +1499,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for "ExpiryFuturesMarketInfo".
Using emphasis (**ExpiryFuturesMarketInfo**
) instead of a proper heading (e.g., ### ExpiryFuturesMarketInfo
) might affect the document's structure and readability, especially in markdown renderers that use headings to generate navigation menus.
@@ -1771,6 +1792,7 @@ No parameters | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for "DerivativePosition".
Using emphasis (**DerivativePosition**
) instead of a proper heading (e.g., ### DerivativePosition
) might affect the document's structure and readability, especially in markdown renderers that use headings to generate navigation menus.
@@ -1780,6 +1802,7 @@ No parameters | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for "Position".
Using emphasis (**Position**
) instead of a proper heading (e.g., ### Position
) might affect the document's structure and readability, especially in markdown renderers that use headings to generate navigation menus.
@@ -1993,6 +2016,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for "DerivativePosition".
Using emphasis (**DerivativePosition**
) instead of a proper heading (e.g., ### DerivativePosition
) might affect the document's structure and readability, especially in markdown renderers that use headings to generate navigation menus.
@@ -2002,6 +2026,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for "Position".
Using emphasis (**Position**
) instead of a proper heading (e.g., ### Position
) might affect the document's structure and readability, especially in markdown renderers that use headings to generate navigation menus.
@@ -2168,6 +2193,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for "Position".
Using emphasis (**Position**
) instead of a proper heading (e.g., ### Position
) might affect the document's structure and readability, especially in markdown renderers that use headings to generate navigation menus.
@@ -2333,6 +2359,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for "EffectivePosition".
Using emphasis (**EffectivePosition**
) instead of a proper heading (e.g., ### EffectivePosition
) might affect the document's structure and readability, especially in markdown renderers that use headings to generate navigation menus.
@@ -2480,6 +2507,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for "PerpetualMarketInfo".
Using emphasis (**PerpetualMarketInfo**
) instead of a proper heading (e.g., ### PerpetualMarketInfo
) might affect the document's structure and readability, especially in markdown renderers that use headings to generate navigation menus.
@@ -2620,6 +2648,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for "ExpiryFuturesMarketInfo".
Using emphasis (**ExpiryFuturesMarketInfo**
) instead of a proper heading (e.g., ### ExpiryFuturesMarketInfo
) might affect the document's structure and readability, especially in markdown renderers that use headings to generate navigation menus.
@@ -2766,6 +2795,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for "PerpetualMarketFunding".
Using emphasis (**PerpetualMarketFunding**
) instead of a proper heading (e.g., ### PerpetualMarketFunding
) might affect the document's structure and readability, especially in markdown renderers that use headings to generate navigation menus.
@@ -2925,6 +2955,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for "TrimmedDerivativeConditionalOrder".
Using emphasis (**TrimmedDerivativeConditionalOrder**
) instead of a proper heading (e.g., ### TrimmedDerivativeConditionalOrder
) might affect the document's structure and readability, especially in markdown renderers that use headings to generate navigation menus.
@@ -3141,6 +3172,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for "OracleType".
Using emphasis (**OracleType**
) instead of a proper heading (e.g., ### OracleType
) might affect the document's structure and readability, especially in markdown renderers that use headings to generate navigation menus.
@@ -3170,6 +3202,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for "TxResponse".
Using emphasis (**TxResponse**
) instead of a proper heading (e.g., ### TxResponse
) might affect the document's structure and readability, especially in markdown renderers that use headings to generate navigation menus.
@@ -3189,6 +3222,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for "ABCIMessageLog".
Using emphasis (**ABCIMessageLog**
) instead of a proper heading (e.g., ### ABCIMessageLog
) might affect the document's structure and readability, especially in markdown renderers that use headings to generate navigation menus.
@@ -3198,6 +3232,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for "Event".
Using emphasis (**Event**
) instead of a proper heading (e.g., ### Event
) might affect the document's structure and readability, especially in markdown renderers that use headings to generate navigation menus.
@@ -3206,6 +3241,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for "StringEvent".
Using emphasis (**StringEvent**
) instead of a proper heading (e.g., ### StringEvent
) might affect the document's structure and readability, especially in markdown renderers that use headings to generate navigation menus.
@@ -3214,6 +3250,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for "EventAttribute".
Using emphasis (**EventAttribute**
) instead of a proper heading (e.g., ### EventAttribute
) might affect the document's structure and readability, especially in markdown renderers that use headings to generate navigation menus.
@@ -3223,6 +3260,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for "Attribute".
Using emphasis (**Attribute**
) instead of a proper heading (e.g., ### Attribute
) might affect the document's structure and readability, especially in markdown renderers that use headings to generate navigation menus.
@@ -3437,6 +3475,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for "OracleType".
Using emphasis (**OracleType**
) instead of a proper heading (e.g., ### OracleType
) might affect the document's structure and readability, especially in markdown renderers that use headings to generate navigation menus.
@@ -3466,6 +3505,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for "TxResponse".
Using emphasis (**TxResponse**
) instead of a proper heading (e.g., ### TxResponse
) might affect the document's structure and readability, especially in markdown renderers that use headings to generate navigation menus.
@@ -3485,6 +3525,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for "ABCIMessageLog".
Using emphasis (**ABCIMessageLog**
) instead of a proper heading (e.g., ### ABCIMessageLog
) might affect the document's structure and readability, especially in markdown renderers that use headings to generate navigation menus.
@@ -3494,6 +3535,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for "Event".
Using emphasis (**Event**
) instead of a proper heading (e.g., ### Event
) might affect the document's structure and readability, especially in markdown renderers that use headings to generate navigation menus.
@@ -3502,6 +3544,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for "StringEvent".
Using emphasis (**StringEvent**
) instead of a proper heading (e.g., ### StringEvent
) might affect the document's structure and readability, especially in markdown renderers that use headings to generate navigation menus.
@@ -3510,6 +3553,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for "EventAttribute".
Using emphasis (**EventAttribute**
) instead of a proper heading (e.g., ### EventAttribute
) might affect the document's structure and readability, especially in markdown renderers that use headings to generate navigation menus.
@@ -3519,6 +3563,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for "Attribute".
Using emphasis (**Attribute**
) instead of a proper heading (e.g., ### Attribute
) might affect the document's structure and readability, especially in markdown renderers that use headings to generate navigation menus.
@@ -3786,6 +3831,7 @@ func main() { | |||
<!-- MARKDOWN-AUTO-DOCS:END --> | |||
|
|||
<br/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a heading instead of emphasis for "DerivativeOrder".
Using emphasis (**DerivativeOrder**
) instead of a proper heading (e.g., ### DerivativeOrder
) might affect the document's structure and readability, especially in markdown renderers that use headings to generate navigation menus.
NOTE: Do not merge this PR until Python SDK v1.6.0 is released in master
Solves CHAIN-85
Summary by CodeRabbit