Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add chain exchange module support #307

Merged
merged 8 commits into from
Feb 28, 2024

Conversation

aarmoa
Copy link
Collaborator

@aarmoa aarmoa commented Feb 27, 2024

  • Added support in the SDK for all chain exchange module queries.
  • Added unit tests and example scripts for all chain exchange module queries.
  • Added support in the SDK for all chain exchange module requests.
  • Added unit tests and example scripts for all chain exchange module requests.
  • Refactored the chain example scripts to move them into separated subfolders for each module.
  • Refactored all chain exchange module messages creation functions in the Composer to follow the Pythonic naming convention. Marked the original functions as deprecated.

abel added 2 commits February 20, 2024 12:52
…new example scripts for all the queries and unit tests.
…er. Added unit tests for new messages. Refactored example scripts to move them into separated subfolders for each module.
@aarmoa aarmoa requested a review from nicolasbaum February 27, 2024 13:13
Copy link
Contributor

coderabbitai bot commented Feb 27, 2024

Warning

Rate Limit Exceeded

@aarmoa has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 11 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 0c61c63 and a435b21.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 71.57757% with 218 lines in your changes are missing coverage. Please review.

Project coverage is 74.60%. Comparing base (0c61c63) to head (a435b21).

Files Patch % Lines
pyinjective/composer.py 61.09% 138 Missing and 18 partials ⚠️
pyinjective/async_client.py 50.00% 54 Missing and 1 partial ⚠️
...ctive/client/chain/grpc/chain_grpc_exchange_api.py 97.18% 0 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #307      +/-   ##
==========================================
+ Coverage   73.34%   74.60%   +1.26%     
==========================================
  Files          49       50       +1     
  Lines        3500     4099     +599     
  Branches      305      349      +44     
==========================================
+ Hits         2567     3058     +491     
- Misses        851      941      +90     
- Partials       82      100      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

abel added 5 commits February 27, 2024 10:50
…new example scripts for all the queries and unit tests.
…er. Added unit tests for new messages. Refactored example scripts to move them into separated subfolders for each module.
@aarmoa
Copy link
Collaborator Author

aarmoa commented Feb 27, 2024

@coderabbitai review

limit_cumulative_quantity: Optional[str] = None,
pagination: Optional[PaginationOption] = None,
) -> Dict[str, Any]:
# Order side could be "Side_Unspecified", "Buy", "Sell"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side_Unspecified???

Copy link

@nicolasbaum nicolasbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EXTENSIVE test coverage :)

@aarmoa aarmoa merged commit a054c55 into dev Feb 28, 2024
11 of 12 checks passed
@aarmoa aarmoa deleted the feat/add_chain_exchange_module_support branch February 28, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants