-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add chain exchange module support #307
Conversation
aarmoa
commented
Feb 27, 2024
- Added support in the SDK for all chain exchange module queries.
- Added unit tests and example scripts for all chain exchange module queries.
- Added support in the SDK for all chain exchange module requests.
- Added unit tests and example scripts for all chain exchange module requests.
- Refactored the chain example scripts to move them into separated subfolders for each module.
- Refactored all chain exchange module messages creation functions in the Composer to follow the Pythonic naming convention. Marked the original functions as deprecated.
…new example scripts for all the queries and unit tests.
…er. Added unit tests for new messages. Refactored example scripts to move them into separated subfolders for each module.
Warning Rate Limit Exceeded@aarmoa has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 11 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #307 +/- ##
==========================================
+ Coverage 73.34% 74.60% +1.26%
==========================================
Files 49 50 +1
Lines 3500 4099 +599
Branches 305 349 +44
==========================================
+ Hits 2567 3058 +491
- Misses 851 941 +90
- Partials 82 100 +18 ☔ View full report in Codecov by Sentry. |
…new example scripts for all the queries and unit tests.
…er. Added unit tests for new messages. Refactored example scripts to move them into separated subfolders for each module.
…ub.com/InjectiveLabs/sdk-python into feat/add_chain_exchange_module_support
@coderabbitai review |
limit_cumulative_quantity: Optional[str] = None, | ||
pagination: Optional[PaginationOption] = None, | ||
) -> Dict[str, Any]: | ||
# Order side could be "Side_Unspecified", "Buy", "Sell" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side_Unspecified???
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EXTENSIVE test coverage :)