COMP: Remove compiler warning of 'nodiscard' function

Prefer inintialization to assignment. Ignoring return value of function declared with 'nodiscard' attribute
InsightSoftwareConsortium · Nov 25, 2024 · fe6f474 · fe6f474
1 parent 6ec1086
commit fe6f474
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 11 deletions.
diff --git a/include/itkConfidenceConnectedSegmentationModule.hxx b/include/itkConfidenceConnectedSegmentationModule.hxx
@@ -74,11 +74,9 @@ ConfidenceConnectedSegmentationModule<NDimension>::GenerateData()
 
   const LandmarkPointListType & points = inputSeeds->GetPoints();
 
-  IndexType index;
-
   for (unsigned int i = 0; i < numberOfPoints; i++)
   {
-    featureImage->TransformPhysicalPointToIndex(points[i].GetPositionInObjectSpace(), index);
+    const IndexType index = featureImage->TransformPhysicalPointToIndex(points[i].GetPositionInObjectSpace());
     filter->AddSeed(index);
   }
 

diff --git a/include/itkConnectedThresholdSegmentationModule.hxx b/include/itkConnectedThresholdSegmentationModule.hxx
@@ -74,11 +74,9 @@ ConnectedThresholdSegmentationModule<NDimension>::GenerateData()
 
   const LandmarkPointListType & points = inputSeeds->GetPoints();
 
-  IndexType index;
-
   for (unsigned int i = 0; i < numberOfPoints; i++)
   {
-    featureImage->TransformPhysicalPointToIndex(points[i].GetPositionInObjectSpace(), index);
+    const IndexType index = featureImage->TransformPhysicalPointToIndex(points[i].GetPositionInObjectSpace());
     filter->AddSeed(index);
   }
 

diff --git a/include/itkFastMarchingSegmentationModule.hxx b/include/itkFastMarchingSegmentationModule.hxx
@@ -101,11 +101,10 @@ FastMarchingSegmentationModule<NDimension>::GenerateData()
 
   const LandmarkPointListType & points = inputSeeds->GetPoints();
 
-  IndexType index;
 
   for (unsigned int i = 0; i < numberOfPoints; i++)
   {
-    featureImage->TransformPhysicalPointToIndex(points[i].GetPositionInObjectSpace(), index);
+    const IndexType index = featureImage->TransformPhysicalPointToIndex(points[i].GetPositionInObjectSpace());
 
     NodeType node;
 

diff --git a/src/itkImageReadRegionOfInterestAroundSeedWrite.cxx b/src/itkImageReadRegionOfInterestAroundSeedWrite.cxx
@@ -114,9 +114,7 @@ main(int argc, char ** argv)
 
   const InputImageType * inputImage = reader->GetOutput();
 
-  InputImageType::IndexType centralIndex;
-
-  inputImage->TransformPhysicalPointToIndex(seedPoint, centralIndex);
+  InputImageType::IndexType centralIndex = inputImage->TransformPhysicalPointToIndex(seedPoint);
 
   InputImageType::SpacingType spacing = inputImage->GetSpacing();