Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MOON-404: Add CheckboxItem and CheckboxGroup components #399

Merged
merged 5 commits into from
Nov 17, 2023
Merged

MOON-404: Add CheckboxItem and CheckboxGroup components #399

merged 5 commits into from
Nov 17, 2023

Conversation

ffffffelix
Copy link
Collaborator

JIRA

https://jira.jahia.org/browse/MOON-404

Description

Checkbox component

  • The onChange functions can be called with the UncontrolledCheckbox component
  • Add tests about onChange and more

CheckboxItem component
Create a component to manage checkboxes in a form context. The component displays a label and an optional description.

CheckboxGroup component
Create to manage a group of CheckboxItems

@ffffffelix ffffffelix added the minor Increment the minor version when merged label Nov 13, 2023
@ffffffelix ffffffelix requested a review from a team November 13, 2023 13:02
AKarmanov
AKarmanov previously approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@AKarmanov AKarmanov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but we should probably remove those logs since this is a lib and we don't want to pollute console

@ffffffelix
Copy link
Collaborator Author

Looks good to me but we should probably remove those logs since this is a lib and we don't want to pollute console

Sorry to have left these logs. I thought I had already removed them. Of course, we don't have to keep unnecessary logs in the library. Thanks for the review.

@ffffffelix ffffffelix requested a review from AKarmanov November 13, 2023 15:33
@ffffffelix ffffffelix merged commit 7a6b8da into develop Nov 17, 2023
2 checks passed
@ffffffelix ffffffelix deleted the MOON-404 branch November 17, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AKarmanov AKarmanov AKarmanov approved these changes

Assignees
No one assigned
Labels
minor Increment the minor version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ffffffelix @AKarmanov