Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MOON-351: Add highlight state for TreeView and MenuItem #401

Merged
merged 4 commits into from
Nov 16, 2023
Merged

MOON-351: Add highlight state for TreeView and MenuItem #401

merged 4 commits into from
Nov 16, 2023

Conversation

ffffffelix
Copy link
Collaborator

JIRA

https://jira.jahia.org/browse/MOON-351

Description

  • Add highlight state for MenuItem
  • Add highlight state for TreeView
  • Add aria attribute to TreeView component for accessibility and tests
  • Use testing-library for TreeView tests
  • Improve typing of TreeView to avoid repeating types for TreeView, ControlledTreeView and UncontrolledTreeView
  • The second argument props of the function toIconComponent become optional

@ffffffelix ffffffelix added the minor Increment the minor version when merged label Nov 15, 2023
@ffffffelix ffffffelix requested a review from tdraier November 15, 2023 16:37
@ffffffelix ffffffelix merged commit 6ec65a4 into develop Nov 16, 2023
2 checks passed
@ffffffelix ffffffelix deleted the MOON-351 branch November 16, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdraier tdraier tdraier approved these changes

Assignees
No one assigned
Labels
minor Increment the minor version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ffffffelix @tdraier