MOON-459: Add Spacing pico and update some spacings components #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g-icon in requiring components style
…rgin left on dropdown chevronDown icon
ffffffelix
reviewed
Dec 12, 2024
| @@ -1,11 +1,6 @@ | |||
| @use "../../tokens/spacings/spacings" as *; | |||
|
|
|||
| .moonstone-IconTextIcon { | |||
There was a problem hiding this comment.
I am wondering if we should use we should use a $spacing-icon_big spacing/gap when we set iconSize to big
There was a problem hiding this comment.
When icons of iconTextIcon are set to size big there is no extra className added to the component, since the spacing is directly assigned as a gap on .moonstone-IconTextIcon I don't have an efficient way of changing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
https://jira.jahia.org/browse/MOON-459
Description
Add global spacing
--spacing-pico& replace--spacing-nanowith$spacing-iconin requiring components style