Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update language.js #69

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ferox0132
Copy link

Hello, sir!
I translated the minigame into Hungarian so that Hungarian users can understand it

best regards: ferox

@Jesper-Hustad
Copy link
Owner

Unfortunately you made changes to the commented out version. https://en.wiktionary.org/wiki/comment_out

I can fix this to make it work tough, thanks for your translation!

@ferox0132
Copy link
Author

Thank you for your quick reply, it would be nice if it were added to the practice page as an optional language.

@tewfik-ghariani
Copy link

I think Jesper's remark was about how the Hungarian language was added to the language.js file

You actually edited directly the template that is commented-out ( with the // characters)
Since it is commented-out, it will not be taken into account

What you have to do is to keep that commented-out section and add another section with your changes above it, but without the // characters

@zsepy0525
Copy link

Hello, as I read and saw, the Hungarian translation was not included in the Minigame. My question would be what we could do about it. Thanks! Sincerely, Zepy

Jesper-Hustad added a commit that referenced this pull request Apr 16, 2023
#69 Thanks to ferox01234 for the translations
@Jesper-Hustad
Copy link
Owner

Jesper-Hustad commented Apr 16, 2023

Sorry for taking so long. I thought this was already fixed.
I have added Hungarian now.
Tell me if you stumble upon any errors or bugs.
Thanks again for the translation

- Üdvözlettel, Jesper

@zsepy0525
Copy link

nopixel_bank_heist_magyar_fordiras.txt
Hello, I found some bugs in the system , expect the translation which is ferox's fault. I dropped you another translation but the github don't accept .js file so I upload that in .txt.
Regards, zsepy

@Jesper-Hustad
Copy link
Owner

@zsepy0525 Those changes are implemented in the current version now.
I believe some things are being lost in translation, but I'm trying my best :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants