Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin.xml - adding mention of JavaScript, TypeScript #33

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ChrisCarini
Copy link

Summary

Adding mention of JavaScript, TypeScript to plugin.xml so that the JB marketplace page for this plugin shows the same list of compatible languages as the README.md in the repo.

@matkoch
Copy link
Member

matkoch commented Nov 24, 2024

JS and TS support in Rider is handled by WebStorm – i.e., not by this plugin.

@matkoch matkoch closed this Nov 24, 2024
@ChrisCarini
Copy link
Author

@matkoch - would the inverse of this be applicable then? aka, should JavaScript, TypeScript be removed from the README.md instead? If so, my patch-1 branch has been updated - are you able to re-open this PR, or should I create a new one?

@matkoch matkoch reopened this Dec 2, 2024
@matkoch
Copy link
Member

matkoch commented Dec 2, 2024

this is still a wrong wording though. the languages are supported in resharper.

@ChrisCarini
Copy link
Author

@matkoch - what would be the correct wording, then? Sorry, I might be a bit confused here - from what you're saying it sounds like:

  1. resharper supports C#, VB, JavaScript, TypeScript and C++
  2. JavaScript and TypeScript support in Rider is provided by WebStorm (not sure how/why Rider is related here; my understanding was that this plugin was for resharper)
  3. this plugin 'works with' C#, VB, JavaScript, TypeScript and C++
  4. this plugin provides cyclomatic complexity feature for C#, VB, and C++ (but not JavaScript, TypeScript?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants