feat: add dynamic metadata for search results #842
+65
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
maggienegm
force-pushed
the
feat-dynamic-metadata-for-search-results
branch
from
4a2c649 to
e22c518
Compare
maggienegm
force-pushed
the
feat-dynamic-metadata-for-search-results
branch
from
e22c518 to
5ff089f
Compare
| @@ -6,7 +6,7 @@ const raleway = Raleway({ subsets: ["latin"] }); | |||
|
|
|||
| export const metadata = { | |||
| description: | |||
| "Check if your npm packages are eligible for Tidelift funding. 💸<", | |||
| "Check if your npm packages are eligible for Tidelift funding. 💸", | |||
There was a problem hiding this comment.
[Praise] Oh, thanks, good catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
This PR introduces dynamic metadata generation for the home/search page. It's metadata is now dynamically generated based on the
searchParamsin the URL:This includes when a valid user has 0 packages eligible for funding based on search parameters. The metadata will look like the following:
When no
searchParamsare provided, the default metadata is used, which is defined inlayout.tsx:Also, something to note is that the API-related logic that was in
page.tsxhas been extracted into a separate file to improve code readability and maintainability.