Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convolution operator ApproxFun.jl#940 #127

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

Jilhg
Copy link
Contributor

@Jilhg Jilhg commented Sep 9, 2024

This implements a convolution operator on (real) periodic segments (see JuliaApproximation/ApproxFun.jl#940). It works for Laurent and Fourier spaces. Also added some testcases.

As I am relatively new to this, please feel free to give any feedback. If you prefer some different style I am happy to change.
In particular:

  • Is it better to override getindex or defaultgetindex?
  • Is the description of the Convolution.jl file sufficient? Also, how can I add it to the docs?
  • Should I provide an example (and if so, where)?

@jishnub
Copy link
Member

jishnub commented Oct 9, 2024

Sorry for the delayed message. I think it's better to extend getindex directly instead of defaultgetindex.

@Jilhg
Copy link
Contributor Author

Jilhg commented Oct 11, 2024

Ok, thank you, I updated this

src/Convolution.jl Outdated Show resolved Hide resolved
@jishnub jishnub merged commit beeed8c into JuliaApproximation:master Oct 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants