Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SparseMatrixColorings #270

Merged
merged 14 commits into from
May 24, 2024
Merged

Use SparseMatrixColorings #270

merged 14 commits into from
May 24, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented May 23, 2024

DI source

  • Remove all the coloring and decompression logic to replace it with the functions from SparseMatrixColorings.jl v0.3
  • Store more things in the sparse Jacobian and Hessian extras to replace the Compressed type
  • Add a fully out-of-place Jacobian and Hessian
  • Make sure that all the functionality used belongs to the public API of SMC (right now color_groups is still private)

DI docs

  • Document the fact that GreedyColoringAlgorithm comes from SparseMatrixColorings.jl and is just reexported, add necessary interlinks

DI tests

  • Add more tests on sparse backends with sparse scenarios (ForwardDiff, Zygote, Enzyme, ForwardDiff/Zygote)
  • Keep tests on sparse backends with dense scenarios
  • Remove MyAutoSparse and instead be explicit every time
  • Re-add type stability tests for ForwardDiff

DIT source

  • Make type stability tests do nothing on < 1.7 where JET isn't usable

DIT CI

  • Split CI in groups like for DI

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.81%. Comparing base (cebfca6) to head (69ad66a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
+ Coverage   96.03%   96.81%   +0.78%     
==========================================
  Files          75       72       -3     
  Lines        3908     3740     -168     
==========================================
- Hits         3753     3621     -132     
+ Misses        155      119      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle marked this pull request as ready for review May 24, 2024 14:44
@gdalle gdalle merged commit b262365 into main May 24, 2024
32 checks passed
@gdalle gdalle deleted the gd/sparsematrixcolorings branch May 24, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants