Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put testing utilities in extension #40

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Put testing utilities in extension #40

merged 3 commits into from
Mar 14, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Mar 14, 2024

  • Define Scenario struct and empty test functions in the DifferentiationInterface.DifferentiationTest submodule
  • Move the rest of the code from test/utils.jl and test/scenarios.jl to the extension DifferentiationInterfaceTestExt, triggered by ForwardDiff, JET, Random, Test
  • Reduce the depth of nested loops by using @testset for
  • Add dummy zero backends to test type stability of the fallback structure
  • Remove allocation checks cause they would need to be done with BenchmarkTools to be accurate
  • Add nice hints for MethodErrors to load extensions with https://docs.julialang.org/en/v1/base/base/#Base.Experimental.register_error_hint

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 86.69202% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 92.60%. Comparing base (b6be4a5) to head (3236b57).

Files Patch % Lines
ext/DifferentiationInterfaceTestExt/test.jl 82.32% 35 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   95.64%   92.60%   -3.04%     
==========================================
  Files          22       26       +4     
  Lines         390      649     +259     
==========================================
+ Hits          373      601     +228     
- Misses         17       48      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle
Copy link
Member Author

gdalle commented Mar 14, 2024

Missing code cov is due to @testsets not being counted, unsure why

@gdalle gdalle merged commit ccb7f43 into main Mar 14, 2024
3 checks passed
@gdalle gdalle deleted the gd/test_extension branch March 14, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants