Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] Change order of arguments #435

Merged
merged 17 commits into from
Sep 5, 2024
Merged

[BREAKING] Change order of arguments #435

merged 17 commits into from
Sep 5, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Sep 1, 2024

Warning

Breaking change

  • DI version bumped to v0.6.0
  • DIT version bumped to v0.6.1

This PR moves the extras argument from the end to the spot right before backend, after all mutated outputs and results. That way we will be able to accommodate additional arguments at the end with a Vararg (not implemented yet).

Before:

operator(f, backend, x, extras)
operator(f!, y, backend, x, extras)
operator!(f, result, backend, x, extras)
operator!(f!, y, result, backend, x, extras)

After:

operator(f, extras, backend, x, args...)
operator(f!, y, extras, backend, x, args...)
operator!(f, result, extras, backend, x, args...)
operator!(f!, y, result, extras, backend, x, args...)

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.53%. Comparing base (4eb9642) to head (324160a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
- Coverage   98.94%   98.53%   -0.42%     
==========================================
  Files         105      105              
  Lines        4280     4293      +13     
==========================================
- Hits         4235     4230       -5     
- Misses         45       63      +18     
Flag Coverage Δ
DI 98.68% <100.00%> (-0.62%) ⬇️
DIT 98.22% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle mentioned this pull request Sep 3, 2024
@gdalle gdalle marked this pull request as ready for review September 5, 2024 06:44
@gdalle gdalle merged commit de23245 into main Sep 5, 2024
60 of 105 checks passed
@gdalle gdalle deleted the gd/extras-move branch September 5, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants