Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disallow complex basis vectors for now #669

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Jan 4, 2025

  • Only allow creation of basis arrays when the eltype is a subtype of Real
  • Enforce that the pushforward fallback for derivative applied to Real inputs

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.36%. Comparing base (9b17e3e) to head (aa4a360).

❗ There is a different number of reports uploaded between BASE (9b17e3e) and HEAD (aa4a360). Click for more details.

HEAD has 21 uploads less than BASE
Flag BASE (9b17e3e) HEAD (aa4a360)
DI 35 14
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #669       +/-   ##
===========================================
- Coverage   97.61%   81.36%   -16.25%     
===========================================
  Files         112      111        -1     
  Lines        5609     5586       -23     
===========================================
- Hits         5475     4545      -930     
- Misses        134     1041      +907     
Flag Coverage Δ
DI 74.19% <100.00%> (-24.57%) ⬇️
DIT 95.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant