Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link error on MSVC #169

Closed
wants to merge 1 commit into from
+8 −4
Closed

Fix link error on MSVC #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-linux-mac.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
body: ${{ github.event.pull_request.body }}
run: |
package="$(echo "$body" | sed -n '1p')"
if [ -z "${package}" ]; then
if [[ "$package" != "http"* ]]; then
package="https://github.com/JuliaInterop/CxxWrap.jl.git"
fi
if [[ "$OSTYPE" != "darwin"* ]]; then
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/test-win.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@ jobs:
cd build
cmake -G "Visual Studio 17 2022" -A x64 -DOVERRIDES_PATH=$HOMEDRIVE/$HOMEPATH/.julia/artifacts/Overrides.toml -DOVERRIDE_ROOT=./ -DAPPEND_OVERRIDES_TOML=ON ..
package="$(echo "$body" | sed -n '1p')"
if [ -z "${package}" ]; then
if [[ "$package" != "http"* ]]; then
package="https://github.com/JuliaInterop/CxxWrap.jl.git"
fi
cmake --build . --config Release
cmake --build . --config Debug
julia -e "using Pkg; Pkg.Registry.add(\"General\"); Pkg.Registry.add(RegistrySpec(url = \"https://github.com/barche/CxxWrapTestRegistry.git\"))"
julia -e "using Pkg; pkg\"add ${package}\"; using CxxWrap"
ctest -j 1 -C Release -V
ctest -j 1 -C Debug -V
4 changes: 4 additions & 0 deletions src/jlcxx.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,10 @@ namespace detail
{
}
};

template struct JLCXX_API BasicArg<false>;
template struct JLCXX_API BasicArg<true>;

}

#ifdef JLCXX_USE_TYPE_MAP
Expand Down
Loading