-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert HelFEM to use new libcxxwrap / libjulia #2320
Conversation
] | ||
include("../../L/libjulia/common.jl") | ||
platforms = libjulia_platforms(julia_version) | ||
platforms = expand_cxxstring_abis(platforms) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This PR also expands the list of supported platforms considerably.
-DUSE_OPENMP=OFF \ | ||
-DHELFEM_BINARIES=OFF -DHELFEM_FIND_DEPS=ON \ | ||
-B build/ -S . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the liberty of sorting these arguments alphabetically and generally aligning them with other JLLs, in the hope that this will help a bit with future maintenance.
First, thanks a lot @fingolfin for all your work on this! Now, I was trying to test this locally, just to make sure it works, but I'm running into some weird version conflict with OpenBLAS:
Changing the compat to 0.3.10 doesn't help either:
I wonder if it's because I'm running BB with Julia 1.6 and 1.7? I do have a non-standard setup. Could we re-run the Yggdrasil builds to make sure that no funky version problem has been introduced to the registry? That said, it looks like the binaries were built successfully on Yggdrasil and I presume were fine. So I don't mind if we just merge this (after updating the version number) and I'll just test the registered binaries, and try to get my local workflow working later. About the questions in the OP:
Regarding the changes to the ordering of the |
@mortenpi Yggdrasil runs on development version of BinaryBuilder and BinaryBuilderbase only for now -- and unfortunately may also need an older snapshot of the Julia master, namely from before the "fake JLL" code was merged there -- any commit before 2eccd8e086ba1b08dd8b4d04e86b548fcf8ec5e5 on the Julia repository should do it. The reason for this is that we need to install specific version of certain JLLs (which include This is a serious problem going forward; I am not sure if anybody has a plan how we'll address this. I am kinda hoping @staticfloat has one, or perhaps @giordano ? |
Thanks for the tip! I compiled Julia off |
Make some progress towards issue #2160
Should not be merged before @mortenpi had a chance to review and comment. Also, there are some questions to discuss:
0.3.X
whereX
is equal to the one in the Julia version 1.X. However, that would mean packages using HelFEM_jll may need to be updated. Then again, I found no such package in the general registry?