[AutoMerge] Do not add "blocked" label if already there #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericphanson
approved these changes
Dec 8, 2024
There was a problem hiding this comment.
good catch! I had assumed adding the label was idempotent and it was slightly better to unconditionally add it to avoid (somewhat unlikely) race conditions, such as due to pr.labels being stale. Did not realize it would bump the PR. Looks like a good fix to me.
I wonder if there's anywhere else I'm not checking due to the same kind of assumptions?
|
This seems to be the only use of |
|
Thank you both! |
|
For the record, PRs with the "blocked" label haven't been updated en masse for over an hour, more specifically since JuliaRegistries/General#120968 was merged, so it'd appear this PR did its job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested, but I presume this should fix #573 (comment).