Move previewer task and channel into functions #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Hope this MR makes ReTest a little more accessible to newcomers. This MR is pretty much done, maybe bar one or two points to clarify (specifically what
align_overflow
andmaxidw
are for in theReTest.jl
), although I am failing about 7 or so tests. These are:Some of these are under a header named
Main.FailingLoops
, so I'm not sure if these are meant to fail or not?This is not meant to introduce any new functionality - just better structure and documentation for myself and others' benefit when reading the code.
EDIT: All the tests above have failing conditions, so this is fine. As an aside, it might be helpful to separate these into a 'failing tests' file so that it's easier for someone to know that this is expected behavior.