Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give GitHub pages workflow contents write permission #316

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Jan 9, 2024

According to github-pages-deploy-action documentation, write permission is necessary:

Screenshot 2024-01-09 at 3 05 33 PM

...should hopefully resolve failing GitHub pages deployments.

According to [github-pages-deploy-action] documentation, write permission is necessary.

[github-pages-deploy-action]: https://github.com/JamesIves/github-pages-deploy-action
@twyatt twyatt added the maintenance General maintenance that doesn't effect the public API. label Jan 9, 2024
@twyatt twyatt requested review from cedrickcooke and a team as code owners January 9, 2024 23:05
@twyatt twyatt requested a review from sdonn3 January 9, 2024 23:05
@twyatt twyatt enabled auto-merge (squash) January 9, 2024 23:06
Copy link

github-actions bot commented Jan 9, 2024

Test Results

 50 files  ±0   50 suites  ±0   14s ⏱️ -3s
252 tests ±0  252 ✅ ±0  0 💤 ±0  0 ❌ ±0 
297 runs  ±0  297 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 51d6f77. ± Comparison against base commit ad9d2eb.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad9d2eb) 79.10% compared to head (51d6f77) 79.10%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #316   +/-   ##
=========================================
  Coverage     79.10%   79.10%           
  Complexity       90       90           
=========================================
  Files            25       25           
  Lines          1254     1254           
  Branches        124      124           
=========================================
  Hits            992      992           
  Misses          203      203           
  Partials         59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twyatt twyatt merged commit c9cf1bf into main Jan 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance General maintenance that doesn't effect the public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants