-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logo URL when deployed #319
Conversation
Test Results 50 files ±0 50 suites ±0 11s ⏱️ -4s Results for commit 0186314. ± Comparison against base commit c9cf1bf. This pull request removes 69 and adds 69 tests. Note that renamed tests count towards both.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #319 +/- ##
=======================================
Coverage ? 79.10%
Complexity ? 90
=======================================
Files ? 25
Lines ? 1254
Branches ? 124
=======================================
Hits ? 992
Misses ? 203
Partials ? 59 ☔ View full report in Codecov by Sentry. |
The Krayon website's root URL starts at
/krayon/
; this makes it so that absolute URLs (e.g./assets/images/..
) don't work because the URL drops the/krayon
root location.The logo is currently broken. 😢
This PR fixes the Krayon logo by passing the asset location to the
relative_url
Jekyll helper function (which will preserve the/krayon
root location in the URL).