Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logo URL when deployed #319

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Fix logo URL when deployed #319

merged 1 commit into from
Jan 18, 2024

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Jan 16, 2024

The Krayon website's root URL starts at /krayon/; this makes it so that absolute URLs (e.g. /assets/images/..) don't work because the URL drops the /krayon root location.

The logo is currently broken. 😢

Screenshot 2024-01-16 at 2 58 31 PM

This PR fixes the Krayon logo by passing the asset location to the relative_url Jekyll helper function (which will preserve the /krayon root location in the URL).

@twyatt twyatt added the maintenance General maintenance that doesn't effect the public API. label Jan 16, 2024
@twyatt twyatt requested review from cedrickcooke and a team as code owners January 16, 2024 22:57
@twyatt twyatt requested a review from Phoenix7351 January 16, 2024 22:57
Copy link

Test Results

 50 files  ±0   50 suites  ±0   11s ⏱️ -4s
252 tests ±0  252 ✅ ±0  0 💤 ±0  0 ❌ ±0 
297 runs  ±0  297 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0186314. ± Comparison against base commit c9cf1bf.

This pull request removes 69 and adds 69 tests. Note that renamed tests count towards both.
com.juul.krayon.color.ColorTests ‑ checkArgbTransformIsCorrect[js, browser, ChromeHeadless120.0.6099.199, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ checkComponentRetrievalIsCorrect[js, browser, ChromeHeadless120.0.6099.199, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ checkComponentsAreMasked[js, browser, ChromeHeadless120.0.6099.199, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ checkCopyWorks[js, browser, ChromeHeadless120.0.6099.199, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ colorConstructor_withFloatInput_matchesIntegerInput[js, browser, ChromeHeadless120.0.6099.199, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ colorConstructor_withLargeFloatInput_throwsException[js, browser, ChromeHeadless120.0.6099.199, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ colorConstructor_withNegativeFloatInput_throwsException[js, browser, ChromeHeadless120.0.6099.199, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ toHexString_withNoTransparency_omitsAlpha[js, browser, ChromeHeadless120.0.6099.199, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ toHexString_withTransparency_includesAlpha[js, browser, ChromeHeadless120.0.6099.199, MacOS10.15.7]
com.juul.krayon.color.OperationsTests ‑ lerp_fromWhiteToBlack_isGray[js, browser, ChromeHeadless120.0.6099.199, MacOS10.15.7]
…
com.juul.krayon.color.ColorTests ‑ checkArgbTransformIsCorrect[js, browser, ChromeHeadless120.0.6099.216, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ checkComponentRetrievalIsCorrect[js, browser, ChromeHeadless120.0.6099.216, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ checkComponentsAreMasked[js, browser, ChromeHeadless120.0.6099.216, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ checkCopyWorks[js, browser, ChromeHeadless120.0.6099.216, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ colorConstructor_withFloatInput_matchesIntegerInput[js, browser, ChromeHeadless120.0.6099.216, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ colorConstructor_withLargeFloatInput_throwsException[js, browser, ChromeHeadless120.0.6099.216, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ colorConstructor_withNegativeFloatInput_throwsException[js, browser, ChromeHeadless120.0.6099.216, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ toHexString_withNoTransparency_omitsAlpha[js, browser, ChromeHeadless120.0.6099.216, MacOS10.15.7]
com.juul.krayon.color.ColorTests ‑ toHexString_withTransparency_includesAlpha[js, browser, ChromeHeadless120.0.6099.216, MacOS10.15.7]
com.juul.krayon.color.OperationsTests ‑ lerp_fromWhiteToBlack_isGray[js, browser, ChromeHeadless120.0.6099.216, MacOS10.15.7]
…

@twyatt twyatt enabled auto-merge (squash) January 16, 2024 23:07
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@c9cf1bf). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #319   +/-   ##
=======================================
  Coverage        ?   79.10%           
  Complexity      ?       90           
=======================================
  Files           ?       25           
  Lines           ?     1254           
  Branches        ?      124           
=======================================
  Hits            ?      992           
  Misses          ?      203           
  Partials        ?       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twyatt twyatt merged commit 4b1fb27 into main Jan 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance General maintenance that doesn't effect the public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants