track: Check for unw_set_caching_policy before using #33
Conversation
llvm libunwind does not implement unw_cache_* functions yet Include inttypes.h got PRI* macros Signed-off-by: Khem Raj <raj.khem@gmail.com>
| if (unw_set_caching_policy(unw_local_addr_space, UNW_CACHE_PER_THREAD)) { | ||
| fprintf(stderr, "WARNING: Failed to enable per-thread libunwind caching.\n"); | ||
| } | ||
| #endif | ||
| #if LIBUNWIND_HAS_UNW_SET_CACHE_SIZE |
There was a problem hiding this comment.
this here is set via cmake/FindLibunwind.cmake - you'll have to add the same check for UNW_CACHE_PER_THREAD and then add it to libunwind_config.h.cmake
|
Interesting, I've never used heaptrack with any other libunwind than the one over at https://github.com/libunwind/libunwind/ - can you tell me how it performs with llvm's libunwind? how do you use it from cmake? if it works well, I'd like to officially document that. |
so far in my little testing I have not seen any issues. but then I have only run one sample. |
llvm libunwind does not implement unw_cache_* functions yet
Include inttypes.h got PRI* macros
Signed-off-by: Khem Raj raj.khem@gmail.com