Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug 379660] Collapse template arguments in flamegraph using checkbox #50

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aravindev
Copy link

This PR is a duplicate of #34 but addresses all the comments since it has been dormant for a while.

I have created a checkbox that can be used to toggle template elision such that the template arguments can optionally be collapsed. This feature is disabled by default.

@milianw Since you were the original reviewer, could you take a look?

@aravindev
Copy link
Author

@SamSaffron @iamsergio @krf @milianw Could one of you assign a reviewer? If this is no longer of interest, feel free to close this PR 😄

@milianw
Copy link
Collaborator

milianw commented Jan 26, 2024

Sorry for the delay, I'll have a look now

Copy link
Collaborator

@milianw milianw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this code is potentially a first step but I think it should be closer to the approach we use in hotspot - see e.g.:

https://github.com/KDAB/hotspot/blob/master/src/util.cpp#L135

generally, we would collapse these everywhere - not just in the flamegraph. the same logic should be used in the tables, and we don't want to do the collapse all the time for view purposes only

@aravindev
Copy link
Author

So, this code is potentially a first step but I think it should be closer to the approach we use in hotspot - see e.g.:

https://github.com/KDAB/hotspot/blob/master/src/util.cpp#L135

generally, we would collapse these everywhere - not just in the flamegraph. the same logic should be used in the tables, and we don't want to do the collapse all the time for view purposes only

Thanks for the pointers. I will update the PR and ping you again!

@aravindev aravindev marked this pull request as draft February 8, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants