Modernize / update to nom 7 #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copies the `expr_opt` macro from nom v4 for the `take_str_eat_garbage` macro. Known Issues: - parsing of examples/simple's test tarballs fails with Incomplete error - parse_octal_ok_test fails Signed-off-by: Constantin Nickel <constantin.nickel@gmail.com>
Signed-off-by: Constantin Nickel <constantin.nickel@gmail.com>
This actually fixes the Incomplete error with examples/simple's tarballs Signed-off-by: Constantin Nickel <constantin.nickel@gmail.com>
This fixes the remaining issue from the nom v6 upgrade. Signed-off-by: Constantin Nickel <constantin.nickel@gmail.com>
clippy::comparison_to_empty clippy::redundant_field_names Signed-off-by: Constantin Nickel <constantin.nickel@gmail.com>
Signed-off-by: Constantin Nickel <constantin.nickel@gmail.com>
Signed-off-by: Constantin Nickel <constantin.nickel@gmail.com>
Signed-off-by: Constantin Nickel <constantin.nickel@gmail.com>
Signed-off-by: Constantin Nickel <constantin.nickel@gmail.com>
|
nom v7 was just released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started with updating to nom 6.2 but 7.0 will probably released in some weeks.
so i kept the PR in draft and just wait for the stable release.