-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python bindings using scikit build core #316
Draft
hendrikmuhs
wants to merge
21
commits into
KeyviDev:master
Choose a base branch
from
hendrikmuhs:scikit-buildcore
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add CI for pybind wrapper use macos-14 runner update tag disable macos-14 remove integration tests skip pp37 adapt sdist fix style fix style revert cibuildwheel changes try to fix sdist move keyvi source out of src install pytest add more match bindings move module import switch to scikit_build remove license file
hendrikmuhs
force-pushed
the
scikit-buildcore
branch
from
December 29, 2024 21:06
4d7cd61
to
3e0fe58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#310 follow up
further investigate options to renovate the python bindings using scikit build core. Scikit build core is a wrapper on top of pybind11 (but also offers other options). With scikit build core we don't need to maintain a pybind subtree.