Merge pull request #41 from ConvertKit/v4-api-tests-broadcasts

v4 API: Tests: Broadcasts

.env.dist.testing

@@ -16,6 +16,7 @@ TEST_TABLE_PREFIX=wp_
 TEST_SITE_WP_URL=http://127.0.0.1
 TEST_SITE_WP_DOMAIN=127.0.0.1
 TEST_SITE_ADMIN_EMAIL=wordpress@convertkit.local
+CONVERTKIT_API_BROADCAST_ID="8697158"
 CONVERTKIT_API_FORM_ID="2765139"
 CONVERTKIT_API_LEGACY_FORM_ID="470099"
 CONVERTKIT_API_LANDING_PAGE_ID="2765196"

.env.example

@@ -24,6 +24,7 @@ CONVERTKIT_OAUTH_ACCESS_TOKEN_NO_DATA=
 CONVERTKIT_OAUTH_REFRESH_TOKEN_NO_DATA=
 CONVERTKIT_OAUTH_CLIENT_ID=
 CONVERTKIT_OAUTH_REDIRECT_URI=
+CONVERTKIT_API_BROADCAST_ID="8697158"
 CONVERTKIT_API_FORM_ID="2765139"
 CONVERTKIT_API_LEGACY_FORM_ID="470099"
 CONVERTKIT_API_LANDING_PAGE_ID="2765196"

src/class-convertkit-api.php

@@ -1018,8 +1018,12 @@ public function request( $endpoint, $method = 'get', $params = array(), $retry_i
 		// Send request.
 		switch ( strtolower( $method ) ) {
 			case 'get':
+				// We deliberate don't use add_query_arg(), as this converts double equal signs (typically
+				// provided by `start_cursor` and `end_cursor`) to a single equal sign, therefore breaking
+				// pagination.  http_build_query() will encode equals signs instead, preserving them
+				// and ensuring paginated requests work correctly.
 				$result = wp_remote_get(
-					add_query_arg( $params, $this->get_api_url( $endpoint ) ),
+					$this->get_api_url( $endpoint ) . '?' . http_build_query( $params ),
 					array(
 						'headers'    => $this->get_request_headers(),
 						'timeout'    => $this->get_timeout(),