Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 API: Use Traits from PHP SDK #37

Merged
merged 37 commits into from
Apr 18, 2024
Merged

v4 API: Use Traits from PHP SDK #37

merged 37 commits into from
Apr 18, 2024

Conversation

n7studios
Copy link
Contributor

Summary

Uses the trait class from the PHP SDK for v4 API methods, removing the equivalent methods from the API class.

Further PRs to follow to reinstate tests.

Testing

Existing tests pass.

Checklist

@n7studios n7studios added the enhancement New feature or request label Apr 15, 2024
@n7studios n7studios added this to the 2.0 milestone Apr 15, 2024
@n7studios n7studios self-assigned this Apr 15, 2024
@n7studios n7studios requested review from a team, noelherrick and corydhmiller and removed request for a team April 15, 2024 13:08
@n7studios n7studios marked this pull request as ready for review April 15, 2024 13:08
Copy link

@noelherrick noelherrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't go over this with a fine-toothed comb since I assume that this was mostly moving code around. Let me know if there are places that need more attention.

@n7studios
Copy link
Contributor Author

I didn't go over this with a fine-toothed comb since I assume that this was mostly moving code around. Let me know if there are places that need more attention.

That's fine, as it's using the PHP SDK's traits class. Further PR's to follow here with tests to make sure the API methods work through the WordPress ConvertKit_API class, and then we'll have some PR's on the main ConvertKit Plugin that implement this v4 API to further confirm no breaking changes. They'll be a lot smaller and easier to review.

@n7studios n7studios merged commit e2ebb1f into v4-api-oauth Apr 18, 2024
5 checks passed
@n7studios n7studios deleted the v4-api-methods branch June 26, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants