-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4 API: Use Traits from PHP SDK #37
Conversation
These are covered in the PHP SDK’s Coding Standards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't go over this with a fine-toothed comb since I assume that this was mostly moving code around. Let me know if there are places that need more attention.
That's fine, as it's using the PHP SDK's traits class. Further PR's to follow here with tests to make sure the API methods work through the WordPress |
…cret v4 API: Exchange API Key and Secret for Access Token
…erfere with `creator_profile` in the v4 API
v4 API: Tests: Accounts
v4 API: Tests: Broadcasts
v4 API: Resources
Summary
Uses the trait class from the PHP SDK for v4 API methods, removing the equivalent methods from the API class.
Further PRs to follow to reinstate tests.
Testing
Existing tests pass.
Checklist