Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 API: Don't map Products #60

Merged
merged 3 commits into from
May 2, 2024
Merged

Conversation

n7studios
Copy link
Contributor

@n7studios n7studios commented Apr 29, 2024

Summary

We don't need to map returned Products into an associative array, as this is already done in the API call.

Testing

  • testRefreshProducts: Test that calling refresh on Products returns and caches Products correctly.
  • testRefreshPosts: Test that calling refresh on Posts returns and caches Posts correctly.

Checklist

@n7studios n7studios added the enhancement New feature or request label Apr 29, 2024
@n7studios n7studios added this to the 2.0 milestone Apr 29, 2024
@n7studios n7studios self-assigned this Apr 29, 2024
@n7studios n7studios marked this pull request as ready for review April 30, 2024 13:18
@n7studios n7studios merged commit cfe73ee into v4-api May 2, 2024
5 checks passed
@n7studios n7studios deleted the v4-api-resources-posts-products branch June 26, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants